Panic during tests if relayer exits abnormally #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
michaelkaplan13,
cam-schultz,
minghinmatthewlam and
bernard-avalabs
as code owners
cam-schultz
reviewed
Jun 5, 2024
cam-schultz
approved these changes
Jun 5, 2024
feuGeneA
approved these changes
Jun 5, 2024
|
only question is whether this was tested perhaps by having a panic in the relayer main with an e2e test. |
|
@minghinmatthewlam Yeah sorry I should have added in the PR description, but I did test that a panic in the relayer would cause the e2e tests to fail immediately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #311
How this works
How this was tested
How is this documented