Update teleporter to v1.0.4 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
commented
Aug 1, 2024
geoff-vball
requested review from
iansuvak,
feuGeneA,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
iansuvak
previously approved these changes
Aug 1, 2024
cam-schultz
previously approved these changes
Aug 1, 2024
iansuvak
previously approved these changes
Aug 7, 2024
cam-schultz
reviewed
Aug 8, 2024
Co-authored-by: cam-schultz <78878559+cam-schultz@users.noreply.github.com> Signed-off-by: Geoff Stuart <geoff.vball@gmail.com>
feuGeneA
reviewed
Aug 12, 2024
|
|
||
| ### Generate Protobuf Files | ||
|
|
||
| [buf](github.com/bufbuild/buf/) is used to generate protobuf definitions for communication with the [Decider service](https://github.com/ava-labs/awm-relayer/blob/main/proto/decider/decider.proto). If you change any of the protobuf definitions you will have to regenerate the `.go` files. To generate these files, run the following command at the root of the project: |
There was a problem hiding this comment.
Should we mention here that you need to manually pre-install buf? Or I wonder if we should modify the script so that it installs it for you, like we do with abigen.
There was a problem hiding this comment.
We should at minimum add this to the Requirements section in the top-level README
There was a problem hiding this comment.
Added this to the Requirements section. Installing the correct version of buf seems quite tricky and platform dependent, so I think sending people to the buf github page is the best course of action
cam-schultz
approved these changes
Aug 15, 2024
iansuvak
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Should fix test failures introduced in teleporter
v1.0.3.