Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds an explicit check against the gas limit specified in the Teleporter message.
It's possible for the required gas limit in a Teleporter message to exceed the block gas limit. This causes the transaction to fail as expected, but also causes the relayer to enter an unhealthy state, preventing it from updating the checkpoint in its database. This can cause compounding latency that will eventually prevent the relayer from running at all.
How this works
Generally speaking, such validity checks are done in
ShouldSendMessage
and theDecider
service. This is done beforesignature aggregation, to short circuit that step if the message is invalid. However, the number of signers impacts the gas estimation, so we can't use that in
ShouldSendMessage
. Instead, I added a hard cap of 12 million gas, which is the C-Chain's 15 million gas block limit minus other Warp message related overhead that is conservatively estimated. Specifically, the 12 million figure assumes:How this was tested
CI, updated unit tests
How is this documented
N/A