Install buf with go #439
Merged
Install buf with go #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
requested review from
iansuvak,
feuGeneA,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
feuGeneA
reviewed
Aug 20, 2024
| @@ -49,8 +49,5 @@ jobs: | |||
| with: | |||
| submodules: recursive | |||
|
|
|||
| - name: Install buf | |||
| uses: bufbuild/buf-setup-action@v1.36.0 | |||
|
|
|||
| - name: Run E2E Tests | |||
There was a problem hiding this comment.
Just to confirm my understanding, this actually wasn't being used anymore here, since we removed the buf usage from the build script, right?
go.mod
Outdated
| @@ -86,19 +86,19 @@ require ( | |||
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | |||
| github.com/pelletier/go-toml/v2 v2.0.8 // indirect | |||
| github.com/rivo/uniseg v0.2.0 // indirect | |||
| github.com/rogpeppe/go-internal v1.10.0 // indirect | |||
| github.com/rogpeppe/go-internal v1.12.0 // indirect | |||
| github.com/russross/blackfriday/v2 v2.1.0 // indirect | |||
There was a problem hiding this comment.
I'm confused why there are any go.{mod,sum} changes in this PR.
There was a problem hiding this comment.
Yeah, not sure what I did lol
cam-schultz
reviewed
Aug 20, 2024
Comment on lines
-17
to
-22
| ## ensure the correct version of "buf" is installed | ||
| BUF_VERSION='1.36.0' | ||
| if [[ $(buf --version | cut -f2 -d' ') != "${BUF_VERSION}" ]]; then | ||
| echo "could not find buf ${BUF_VERSION}, is it installed + in PATH?" | ||
| exit 255 | ||
| fi |
There was a problem hiding this comment.
We should still keep this no? Otherwise calling this script on its own has no guarantee that the code is generated using the expected version.
There was a problem hiding this comment.
I've just added an install step here as well, which is basically a no-op if it's already there.
geoff-vball
force-pushed
the
go-install-buf
branch
from
e546abc to
ba83590
Compare
cam-schultz
approved these changes
Aug 20, 2024
iansuvak
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We currently have an issue where the
bufversion needs to be updated in multiple locations, and it is tricky for users to install the correct version.This PR creates a single source of truth, and removed the need for the install step in the github workflows.