Only write to listener's app relayers #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cam-schultz
requested review from
iansuvak,
feuGeneA,
geoff-vball,
minghinmatthewlam,
bernard-avalabs and
michaelkaplan13
iansuvak
approved these changes
Aug 20, 2024
minghinmatthewlam
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently, the message coordinator singleton dispatches to every block from every chain to every application relayer. If there are messages in the block, they will still be processed as expected by the appropriate application relayer, and the other application relayers are very likely to simply no-op. However, if there are no messages in the blocks, then all application relayers will instead stage the height to be committed to the database. The committed heights will be out of order since they don't pertain to the expected chain, so no heights will be written. This breaks block checkpointing, and can cause OOM as the queue of pending blocks grows unbounded.
How this works
The message coordinator only dispatches to application relayers whose source chain ID matches the block being processed.
How this was tested
CI. Created #448 to add unit tests for the message coordinator
How is this documented
N/A