Tracked subnets fix #460
Merged
Tracked subnets fix #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iansuvak
requested review from
feuGeneA,
geoff-vball,
minghinmatthewlam,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
iansuvak
force-pushed
the
tracked_subnets_fix
branch
from
3689b22 to
9068345
Compare
geoff-vball
approved these changes
Aug 27, 2024
michaelkaplan13
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As of
avalanchego v1.11.7it's no longer valid for nodes to set the primary network ID in their tracked subnets. Setting it anyway causes peers to disconnect from the relayer at the 22.5 second Ping interval.How this works
Only sets non-primary networkIDs as tracked subnets
How this was tested
Manually ran a relayer connected to fuji/echo/dispatch and confirmed that there are no disconnects when looking at the logs after this fix and there are without it.
How is this documented
N/A