Add extra peer endpoints to aggregator #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemadero
requested review from
iansuvak,
geoff-vball,
bernard-avalabs,
michaelkaplan13 and
cam-schultz
|
Should we convert this to a draft for now? I think that this is okay to use for testing in this instance but shouldn't canonical info reliably return the way to connect to validators in the long term? |
connecting an instance to a devnet is very much needed, not for testing on an instance, but to support Anyway I believe it is good idea to have this as an option. |
Merged
|
closed since superseded by #521 which is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Certain devnet endpoints does not correctly return all external nodes connected to the devnet validators.
As is currently the case with etna. The PR enables passing to the aggregator nodes that are not included
in canonical info.peers from the devnet endpoint.
How this works
It enables passing to the aggregator a list of endpoints from which to generate extra peers.
How this was tested
CLI branch that connects a local node to etna and needs the aggregator to include it in the aggregation
How is this documented