add ABI fuzz tests and dependencies #993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
changed the title
marun
reviewed
Nov 14, 2023
|
The PR that actually runs fuzz tests: |
marun
previously approved these changes
Nov 14, 2023
ceyonur
commented
Nov 15, 2023
| // (c) 2019-2023, Ava Labs, Inc. All rights reserved. | ||
| // See the file LICENSE for licensing terms. | ||
|
|
||
| //go:build fuzz |
There was a problem hiding this comment.
There was a g++/cppgc link problem with v8go package in test runs: https://github.com/ava-labs/subnet-evm/actions/runs/6866130434/job/18671676772?pr=993.
I did not want to change our whole build flags just because of this tests, as these will run every day with fuzz.yml CI flow. So I just ignored this in build in tests and added specific fuzz tag.
ceyonur
commented
Nov 15, 2023
| @@ -51,6 +51,7 @@ require ( | |||
| golang.org/x/time v0.1.0 | |||
| google.golang.org/protobuf v1.31.0 | |||
| gopkg.in/natefinch/lumberjack.v2 v2.0.0 | |||
| rogchap.com/v8go v0.9.0 | |||
There was a problem hiding this comment.
Unfortunately I had to add this as a new dependency because goja only supports ES5+ and ethers library is not ES5 compatible. I tried my luck with transpilers + polyfilly but couldn't really get it working with goja.
marun
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds ABI package pack vs Ethers (JS library) Pack fuzz tests.
Closes: #769
How this works
abipackagePack()and Ether'sEncodeValuefunctions.v8golibrary to run JSEtherslibrary.How this was tested
Adds fuzz tests.
How is this documented
No need.