add empty / error header constructor, put u32::MAX as size for compac… #84
Conversation
…t datalookup in case of error
Leouarz
requested review from
markopoloparadox,
ToufeeqP and
aterentic-ethernal
| @@ -33,6 +33,7 @@ pub enum Error { | |||
| )] | |||
| pub struct DataLookup { | |||
| pub(crate) index: Vec<(AppId, DataLookupRange)>, | |||
| pub(crate) is_error: bool, | |||
There was a problem hiding this comment.
What about making DataLookup optional in the header instead of adding is_error?
There was a problem hiding this comment.
Or even Result?
There was a problem hiding this comment.
I'm not in favour of doing drastic changes again, any thoughts @markopoloparadox ?
There was a problem hiding this comment.
As discussed in the previous call, we cannot touch CompactDataLookup for the time being. Making DataLookup an Option or Result will not yield the desired outcome since we need that struct to be valid in order to decode it into CompactDataLookup.
IE it easier to add a flag and create a corresponding CompactDataLookup out of it then to write special functions to handle Option<DataLookup> into CompactDataLookup conversion and vice versa
…t datalookup in case of error