Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrated to FungibleAdapter #650

Merged
merged 6 commits into from
Oct 3, 2024
Merged

migrated to FungibleAdapter #650

merged 6 commits into from
Oct 3, 2024

Conversation

ToufeeqP
Copy link
Contributor

@ToufeeqP ToufeeqP commented Aug 29, 2024

Pull Request type

Please add the labels corresponding to the type of changes your PR introduces:

  • Feature
  • Bugfix

Companion(s)

SDK
Avail-core

Description

Related Issues

Testing Performed

Checklist

  • I have performed a self-review of my own code.
  • The tests pass successfully with cargo test.
  • The code was formatted with cargo fmt.
  • The code compiles with no new warnings with cargo build --release and cargo build --release --features runtime-benchmarks.
  • The code has no new warnings when using cargo clippy.
  • If this change affects documented features or needs new documentation, I have created a PR with a documentation update.

@ToufeeqP ToufeeqP marked this pull request as ready for review September 2, 2024 06:22
Copy link
Contributor

@Leouarz Leouarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@fmiguelgarcia fmiguelgarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only pending thing is the polkadot-sdk dependency.

@ToufeeqP ToufeeqP merged commit 60356e9 into main Oct 3, 2024
16 checks passed
@ToufeeqP ToufeeqP deleted the toufeeq/fix-fee-payment branch October 3, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants