Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract PropertiesParser (so that it is accessible to plugins) #117

Merged
merged 5 commits into from
Feb 3, 2024

Conversation

rbygrave
Copy link
Contributor

@rbygrave rbygrave commented Feb 2, 2024

No description provided.

@rbygrave rbygrave self-assigned this Feb 2, 2024
Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe only do an RC candidate just in case you think of something else

@rbygrave
Copy link
Contributor Author

rbygrave commented Feb 3, 2024

maybe only do an RC candidate

Yeah, good call. I am looking to add a configuration.refresh() to manually trigger a refresh on any configuration sources (like AWS AppConfig). This will be mostly for use with Lambda.

@rbygrave rbygrave added this to the 3.12 milestone Feb 3, 2024
@rbygrave rbygrave merged commit aad9045 into master Feb 3, 2024
7 checks passed
@rbygrave rbygrave deleted the feature/extract-propertiesparser branch February 3, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants