Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configuration.Builder for manual construction #90

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

rob-bygrave
Copy link
Contributor

  • Adds Configuration.Builder for manually creating a Configuration
  • Refactor extract the internal CoreConfiguration.postLoad() logic

This is to support use of Configuration where the configuration source key/values is all controlled and explicitly populated.

- Adds Configuration.Builder for manually creating a Configuration
- Refactor extract the internal CoreConfiguration.postLoad() logic
Copy link
Collaborator

@SentryMan SentryMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Add includeResourceLoading() to Configuration.Builder
- Move eval into Configuration.Builder so that it is performed once and cover the loaded resources + any explicitly set key/values
@rbygrave rbygrave self-assigned this Sep 28, 2023
@rbygrave rbygrave added this to the 3.8 milestone Sep 28, 2023
@rbygrave rbygrave merged commit 8fd6bff into master Sep 28, 2023
6 checks passed
@rbygrave rbygrave deleted the feature/putAll-wildcard branch September 28, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants