-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency on SLF4J - Migrate to System.Logger #156
Comments
Options:
Sub-questions:Why is 2.0-alpha still an alpha version? For me, I wonder if can we try and get a PR into slf4j-api 1.7.x to add module-info? If we managed to do that, that would help a LOT of projects and soften the upgrade path to module path. I don't know the details / differences with 2.0-alpha, what are the breaking changes from slf4j-api 1.7.x. to 2.0.x ? ... but getting 1.7.x to support module-info seems like a good thing to try and do. Hmmm. |
Another option: Use multi-release jar to use SLF4J 1.7 for Java 8 and Platform Logger for Java 9+ ( |
I have had a closer look at slf4j 2.x to see what was going on and why it's still alpha etc. Also just a little look at That is, I'm starting to remove my bias away from slf4j-api and leaning towards the thought that
We could do this or even use JUL for Java 8 and Platform Logger for 9+. At some point we also raise the question of moving our minimal java dependency from 8 to 11 which would mean we should just use the Java Platform Logger / Next steps |
Note that I have the PR/branch https://github.com/avaje/avaje-inject/pull/172/files ... but I am somewhat unsatisfied with it at the moment. My thought is that we almost certainly should change to https://www.reddit.com/r/java/comments/rdv98z/have_you_ever_wondered_how_javas_logging/ho49gp1/ |
PR #190 bumps to Java 11 and uses System.Logger. Closing this as now fixed. |
Can dependency on SLF4J be removed or library updated to 2.0-alpha? 1.7 is not modularized.
The text was updated successfully, but these errors were encountered: