Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typeuse annotations not getting trimmed properly #363

Merged
merged 8 commits into from
Jul 4, 2023
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions inject-generator/src/main/java/io/avaje/inject/generator/Util.java
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
package io.avaje.inject.generator;

import java.util.Optional;
import static io.avaje.inject.generator.ProcessingContext.isImportedType;

import java.util.Optional;
import java.util.regex.Matcher;
import java.util.regex.Pattern;

import javax.lang.model.element.AnnotationMirror;
import javax.lang.model.element.Element;
import javax.lang.model.type.DeclaredType;
import javax.lang.model.type.TypeMirror;

final class Util {
private static final Pattern ANNOTATION_REGEX = Pattern.compile("(@.*?)(?=(?:[^\"]*\"[^\"]*\")*[^\"]*$)\\s");
SentryMan marked this conversation as resolved.
Show resolved Hide resolved

static final String ASPECT_PROVIDER_PREFIX = "io.avaje.inject.aop.AspectProvider<";
static final String PROVIDER_PREFIX = "jakarta.inject.Provider<";
Expand Down Expand Up @@ -49,23 +53,27 @@ static String trimGenerics(String type) {
return type.substring(0, i);
}


/** Trim off annotations from the raw type if present. */
public static String trimAnnotations(String type) {
final int pos = type.indexOf(".@");
if (pos == -1) {
return type;
public static String trimAnnotations(String input) {

// Use a pattern matcher to find the first occurrence of the pattern
final Matcher matcher = ANNOTATION_REGEX.matcher(input);
String result = input;
while (matcher.find()) {
final String matchedSubstring = matcher.group();
result = result.replace(matchedSubstring, "");
}
return type.substring(0, pos + 1) + type.substring(type.lastIndexOf(' ') + 1);

return result.toString();
}

public static String sanitizeImports(String type) {
final int pos = type.indexOf("@");
if (pos == -1) {
return type.replace("[]", "");
return type.replaceAll("[^\\n\\r\\t $;\\w.]", "");
}
final var start = pos == 0 ? type.substring(0, pos) : "";
return start + type.substring(type.lastIndexOf(' ') + 1).replace("[]", "");
return start + type.substring(type.lastIndexOf(' ') + 1).replaceAll("[^\\n\\r\\t $;\\w.]", "");
}

static String nestedPackageOf(String cls) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,19 @@ void validImportType() {
assertTrue(Util.validImportType("other.pack.Foo"));
}

@Test
void trimmedAnnotation() {
assertEquals(
"java.util.List<java.lang.String>",
Util.trimAnnotations(
"java.util.@jakarta.validation.constraints.NotEmpty(\"message(); ,\") List<java.lang.@jakarta.validation.constraints.NotNull String>"));
assertEquals("int", Util.trimAnnotations("@jakarta.validation.constraints.Positive int"));
assertEquals(
"java.util.Map<String,String>",
Util.trimAnnotations(
"java.util.Map<@jakarta.validation.constraints.Positive String,String>"));
}

@Test
void validImportType_not() {
assertFalse(Util.validImportType("void"));
Expand Down Expand Up @@ -159,5 +172,6 @@ void sanitizeImports() {
assertEquals("my.Foo", Util.sanitizeImports("@annotationMcgee my.Foo"));
assertEquals("my.Foo", Util.sanitizeImports("@org.bar.annotationMcgee my.Foo[]"));
assertEquals("my.Foo", Util.sanitizeImports("@org.bar.annotationMcgee my.Foo"));
assertEquals("java.util.String", Util.sanitizeImports("java.util.String>"));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package io.avaje.inject.generator.models.valid.aspect;

import java.util.Map;

import io.avaje.inject.Component;
import io.avaje.inject.generator.models.valid.Timed;

@Component
public class MethodTest {

@Timed
void test(@Param Map<@TypeUse String, String> str, @Param int inty, String regular) {}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
package io.avaje.inject.generator.models.valid.aspect;

public @interface Param {}
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
package io.avaje.inject.generator.models.valid.aspect;

import static java.lang.annotation.ElementType.TYPE_USE;
import static java.lang.annotation.RetentionPolicy.RUNTIME;

import java.lang.annotation.Retention;
import java.lang.annotation.Target;

@Target(TYPE_USE)
@Retention(RUNTIME)
public @interface TypeUse {}