Backwards Compatible Generic Modules #567
Conversation
inject-maven-plugin/src/main/java/io/avaje/inject/mojo/AvajeModuleData.java
Outdated
Show resolved
Hide resolved
| ServiceLoader.load(Module.class, newClassLoader).forEach(avajeModules::add); | ||
| ServiceLoader.load(AvajeModule.class, newClassLoader).stream() | ||
| .map(Provider::get) | ||
| .filter(AvajeModule.class::isInstance) |
inject/src/test/java/io/avaje/inject/LegacyBeanScopeBuilderTest.java
Outdated
Show resolved
Hide resolved
|
Did you hit this issue of desiring 10.x to be backwards compatible or did someone else? Just wondering of the pain level. Also just to say I'm kind of not loving "AvajeModule" as a name ... so I'm hoping that something better might come to me. |
|
Yeah, I noticed that all the plugins and libraries I've made at work ceased to function |
The maven plugin/generator is unable to get the type array from legacy plugins. |
I was thinking of I got a couple of alternate options (just spitballing here):
|
Yeah, that makes sense. IMO the original "Module" was a poor choice by me. "InjectModule" is taken by the annotation (which seems ok) ... so I'm definately warming to AvajeModule (it's mostly used internally). I should get to review this again today. Great work by the way !!! |
Restore the Module interface to use Class<?> as per 9.x The AvajeModule interface changes this to Type
…575) Restore the Module interface to use Class<?> as per 9.x The AvajeModule interface changes this to Type
Adds all the backwards compatibility stuff from #566 minus the SPI changes