Write SPIs to META-INF/generated-services so that they can be merged later via avaje-spi-service #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SentryMan
commented
Jun 21, 2024
| @@ -67,7 +68,7 @@ void testGeneration() throws Exception { | |||
| List.of("--release=" + Integer.getInteger("java.specification.version")), | |||
| null, | |||
| files); | |||
| task.setProcessors(Arrays.asList(new InjectProcessor())); | |||
| task.setProcessors(List.of(new InjectProcessor(), new ServiceProcessor())); | |||
There was a problem hiding this comment.
@rbygrave you can probably use your IDE here to debug and understand what's going on if it's still not making intuitive sense.
rbygrave
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now relies on spi-service to write spis
relies on avaje/avaje-spi-service#25
Note: This ultimately is required because with the change to a common service interface of InjectExtension we now more likely get multiple services registering for the same InjectExtension api interface - so those need to be merged into the same META-INF/services file via avaje-spi-service.