Fix partial compile regression introduced in 10.1 via #645 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10.0-RC5 introduced a regression that stops "Partial Compilation" from working. This is due to the ProcessingContext.isInjectModule() not correctly detecting the current module. This meant no existing module was found, no dependency meta data for the module was read, a new module is created for the components included in the partial compile and generally that will fail with missing dependencies. A workaround is to perform a full compile (but this isn't really a workable solution - its important that partial compile works).
Fixes a regression that breaks partial compilation when qualifiers are used. Regression introduced in 10.1 via: https://github.com/avaje/avaje-inject/pull/645/files With this regression we observe compile errors stating that dependencies with qualifiers are missing. When reviewing the relevant generated @metadata dependsOn attributes in the generate source we see that there are qualifiers incorrectly appended to the factory type. The fix is in the MetaData constructor, such that the dependsOn does NOT use the name/qualifier of the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression that breaks partial compilation when qualifiers are used.
Regression introduced in 10.1 via:
https://github.com/avaje/avaje-inject/pull/645/files
With this regression we observe compile errors stating that dependencies with qualifiers are missing. When reviewing the relevant generated @metadata dependsOn attributes in the generate source we see that there are qualifiers incorrectly appended to the factory type.
The fix is in the MetaData constructor, such that the dependsOn does NOT use the name/qualifier of the type.