Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Module Path to Find External Modules #718

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Use Module Path to Find External Modules #718

merged 5 commits into from
Oct 31, 2024

Conversation

SentryMan
Copy link
Collaborator

@SentryMan SentryMan commented Oct 30, 2024 •
edited
Loading

This works but it has a few caveats:

  • it will only work if the application being compiled has a module-info.java
  • The processor can only read external AvajeModules if the package is exported (or if the external lib does not have a module-info.java)

Resolves #716

@SentryMan SentryMan requested a review from rbygrave October 30, 2024 23:19
@SentryMan SentryMan self-assigned this Oct 30, 2024
@SentryMan SentryMan added the enhancement New feature or request label Oct 30, 2024
@SentryMan SentryMan added this to the 10.5 milestone Oct 30, 2024
@SentryMan
Copy link
Collaborator Author

@rbygrave yeah I'm good with this

@SentryMan SentryMan enabled auto-merge (squash) October 31, 2024 00:31
@SentryMan SentryMan merged commit 1b897aa into avaje:master Oct 31, 2024
7 checks passed
@SentryMan SentryMan deleted the external-module-path branch October 31, 2024 01:06
@SentryMan SentryMan mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-bygrave rob-bygrave rob-bygrave approved these changes

@rbygrave rbygrave Awaiting requested review from rbygrave

Assignees

@SentryMan SentryMan

Labels
enhancement New feature or request
Projects
None yet
Milestone
10.5
Development

Successfully merging this pull request may close these issues.

Use Elements#getAllModuleElements to read external modules
2 participants
@SentryMan @rob-bygrave