Add @Json.Creator #189
Merged
Add @Json.Creator #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbygrave
approved these changes
Nov 30, 2023
rbygrave
added a commit
that referenced
this pull request
Nov 30, 2023
rbygrave
added a commit
that referenced
this pull request
Nov 30, 2023
rbygrave
reviewed
Nov 30, 2023
| @@ -139,6 +139,16 @@ public boolean hasJsonAnnotation() { | |||
|
|
|||
| @Override | |||
| public void read() { | |||
|
|
|||
| @@ -470,6 +481,8 @@ private void writeJsonBuildResult(Append writer, String varName) { | |||
| // assuming name matches field here? | |||
| writer.append(constructorParamName(name + (frequency == 0 ? "" : frequency.toString()))); | |||
| } | |||
| } else { | |||
| return element; | ||
| } | ||
|
|
||
| public VariableElement getElement() { |
| jsonCreator = | ||
| jsonCreator.or( | ||
| () -> | ||
| baseType.getEnclosedElements().stream() |
| jsonCreator | ||
| .map( | ||
| ex -> { | ||
| var mods = ex.getModifiers(); |
| TypeReader(TypeElement baseType, TypeElement mixInType, NamingConvention namingConvention, String typePropertyKey) { | ||
| private final boolean hasJsonCreator; | ||
|
|
||
| TypeReader( |
| * @Json | ||
| * public record Product( ... ) { | ||
| * | ||
| * public static Product factory(@Json.Alias("alias") String name){ |
There was a problem hiding this comment.
Missing annotation in example javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can annotate a constructor/factory method with
@Json.Creatorto get more control on how an object gets deserialized. (or use mix-ins to switch things up entirely)resolves #187