Ensure watch mode works when AVA is called outside the package root

[novemberborn]

Given the following project layout:

/package.json
/lib/foo.js
/test/foo.js

Watch mode works as expected when invoked like this:

cd /
$(npm bin)/ava -w test/foo.js

But not if invoked like:

cd /test
$(npm bin)/ava -w foo.js

See also #863.

There is a $40.00 open bounty on this issue. Add more on Issuehunt.

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[novemberborn]

See also #937, which may just be why watch mode isn't working as it should.

[sindresorhus]

@novemberborn I this related to #32 (comment) Would fixing that issue help this case?

[novemberborn]

@sindresorhus no, the watcher runs in the main thread. The CLI behaves differently with watch mode depending on the directory you're in when you start it. This has been fixed for non-watch mode (#863).

[timurtu]

Hello, I'd like to contribute if anyone else hasn't taken this. By outside package root do you mean calling './(project-root)/node_modules/.bin/ava -w' from a shell (or child_process) isn't working?

[sindresorhus]

This is PR welcome again, as #985 went stale.
Make sure to take into account the feedback left in #985.

[IssueHuntBot]

@IssueHunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[okandas]

@novemberborn running

cd /
$(npm bin)/ava -w test/foo.js

this line will check if the files in watch are a true source this.avaFiles.isSource(filePath) and return true if its indeed a source file ..

isSource

Once inside the isSource method I wanted to check the difference between calling

$(npm bin)/ava -w test/foo.js
and
$(npm bin)/ava -w foo.js

by logging as below

		// Ignore paths outside the current working directory.
		// They can't be matched to a pattern.

		if (filePath.startsWith('../')) {
			console.log(filePath)
			console.log('returns false because ignores paths outside the current working directory')
			return false;
		}

and this is what I got

( $(npm bin)/ava -w test/foo.js )

node_modules/ava/index.js
node_modules/ava/lib/worker/main.js
lib/foo.js

and

( $(npm bin)/ava -w foo.js )

../node_modules/ava/index.js
../node_modules/ava/lib/worker/main.js
../lib/foo.js

meaning ../lib/foo.js remains untracked as testDependecy when we call ( $(npm bin)/ava -w foo.js )

fileStartsWith

[novemberborn]

I've refactored the file selection and classification logic. I'm not sure if this bug still exists.