Removed unused code in mini reporter #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarlehansen
changed the title
jarlehansen
changed the title
vadimdemedes
suggested changes
Jan 4, 2017
| var reporter = miniReporter(); | ||
| reporter.failCount = 2; | ||
|
|
||
| var err1 = new Error('failure one'); |
| compareLineOutput.SKIP_UNTIL_EMPTY_LINE, | ||
| '', | ||
| '' | ||
| ].concat( |
There was a problem hiding this comment.
=> .concat(expectedStack.split('\n'))
| var output = reporter.finish(runStatus); | ||
|
|
||
| var expectedStack = colors.error(' failure two\n') + colors.errorStack('stack line with trailing whitespace'); | ||
| expectedStack = expectedStack.split('\n'); |
There was a problem hiding this comment.
Remove this and see comment below.
| err1.stack = beautifyStack(err1.stack); | ||
|
|
||
| var runStatus = { | ||
| errors: [{ |
There was a problem hiding this comment.
could be:
errors: [
{title: 'failed one', error: err},
{title: 'failed two'}
]
…vior is still the same
jarlehansen
force-pushed
the
improve-coverage-mini-reporter
branch
from
37b46e4
to
d78f63c
Compare
|
@vadimdemedes all good suggestions for improvements, I have updated the pull request. |
|
Thank you, @jarlehansen! |
vadimdemedes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases code coverage #161 in mini-reporter by removing unused code and added a new test to verify the behaviour.
The removed if-statement seems to be unnecessary because the same value is check in the beginning of the function.