Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve thumbnail load times #6032

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Improve thumbnail load times #6032

wants to merge 1 commit into from

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Sep 13, 2024

IndexedFiles must be reindexed for this work to have an effect. Without reindexing all thumbnails will display as the missing content icon.

Improvements needed:

  • Populate with icon data instead of asset_path when item is missing thumbnail
  • Because of being in the term frequency method, the work as it stands breaks the browse page.
    • Move thumbnail logic out of term frequency method and into its own method
    • Or rework the checks and search logic so that the term frequency method runs without causing an error when solr_parameters[:q] is missing.
  • This work probably needs an explicit fallback for when a video is missing a thumbnail or content_ss is otherwise unable to be pulled from solr.

Investigation needed:

  • Does this affect overall search load times? Need to test with larger datasets.
  • Ensure that the thumbnails are returned for both browse and search, and that this doesn't break other routes that run through the search builder/catalog controller.
  • Is there a way to return the thumbnail data without needing a reindex?

IndexedFiles must be reindexed for this work to have an effect. Without
reindexing all thumbnails will display as the missing content icon.

Improvements needed:
- Populate with icon data instead of `asset_path` when item is missing
  thumbnail
- Move thumbnail logic out of termfreq method and into its own method
- This work probably needs an explicit fallback for when a video is
  missing a thumbnail or `content_ss` is otherwise unable to be pulled
  from solr.

Investigation needed:
- Does this affect overall search load times? Need to test with larger
  datasets.
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work, but I'm unsure if it is the best solution given the need to reindex and I'm wondering if data-uris might end up being more of a problem than an improvement. I'd like to leave this PR in draft and talk over how it compares to alternative solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants