Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Render session details with session occurrences #185

Merged
merged 2 commits into from
Aug 4, 2024
Merged

Feat: Render session details with session occurrences #185

merged 2 commits into from
Aug 4, 2024

Conversation

Bahugunajii
Copy link
Member

@Bahugunajii Bahugunajii commented Jun 28, 2024 •
edited
Loading

Description

  • Render session details with session occurrences
  • Fixed spelling

Checklist

  • Self-testing

@Bahugunajii Bahugunajii changed the title render session with session occurrences Feat: Render session with session occurrences Jun 28, 2024
@Bahugunajii Bahugunajii changed the title Feat: Render session with session occurrences Feat: Render session occurrences with session Jun 28, 2024
suryabulusu
suryabulusu reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@suryabulusu suryabulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comment.. unsure if we have to return all session occurrences along with session.

in session manager, we retrieve 50 sessions at once on each page. The request would be too large if we get all their corresponding occurrences

@Bahugunajii Bahugunajii changed the title Feat: Render session occurrences with session Feat: Render session details with session occurrences Jul 22, 2024
@Bahugunajii
Merge branch 'main' of https://github.com/avantifellows/db-service in…
c381579 
…to feat/render-session-with-session-occurrences
@Bahugunajii Bahugunajii merged commit 314a9fa into main Aug 4, 2024
1 check passed
@Bahugunajii Bahugunajii deleted the feat/render-session-with-session-occurrences branch August 4, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suryabulusu suryabulusu suryabulusu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bahugunajii @suryabulusu