Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger email on user approved #164

Merged
merged 8 commits into from
May 14, 2021
Merged

Trigger email on user approved #164

merged 8 commits into from
May 14, 2021

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented May 14, 2021 •
edited
Loading

Fixes #163

Summary

  • for users who have logged in through their email, when the user status is changed to approved, sends an email trigger notifying them of the approval.

Test Plan

Tested locally.

TODOs

  • add env variables on staging
  • test on staging
  • add env variables on production
  • test on production

@pep8speaks
Copy link

pep8speaks commented May 14, 2021 •
edited
Loading

Hello @dalmia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-05-14 18:45:38 UTC

@dalmia dalmia added this to the v0.1.3 milestone May 14, 2021
@dalmia dalmia temporarily deployed to Staging May 14, 2021 12:43 Inactive
deepansh96
deepansh96 reviewed May 14, 2021
View reviewed changes
users/views.py Outdated Show resolved Hide resolved
@dalmia dalmia merged commit b1aee28 into master May 14, 2021
@dalmia dalmia deleted the feature/trigger-waitlist-email branch May 14, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepansh96 deepansh96 deepansh96 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.

Set up Email trigger when user is approved (for users who logged in with email)
3 participants
@dalmia @pep8speaks @deepansh96