Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for AWS Cognito #166

Merged
merged 4 commits into from
May 18, 2021
Merged

Support for AWS Cognito #166

merged 4 commits into from
May 18, 2021

Conversation

rathorevaibhav
Copy link
Member

@rathorevaibhav rathorevaibhav commented May 17, 2021 •
edited by dalmia
Loading

Summary

  1. Generalized the Identity Provider code and documentation.
  2. Plio now supports both Auth0 and AWS Cognito.

Test Plan

Tested locally with cubejs dev mode false. Needs more hands on testing.

  • test it on staging
  • test it on production

@rathorevaibhav rathorevaibhav added this to the v0.1.3 milestone May 17, 2021
@rathorevaibhav rathorevaibhav self-assigned this May 17, 2021
dalmia
dalmia reviewed May 18, 2021
View reviewed changes
users/views.py Outdated Show resolved Hide resolved
dalmia
dalmia reviewed May 18, 2021
View reviewed changes
docs/ENV.md Outdated Show resolved Hide resolved
@rathorevaibhav @dalmia
Apply suggestions from code review
e6a291c 
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
@pep8speaks
Copy link

pep8speaks commented May 18, 2021 •
edited
Loading

Hello @rathorevaibhav! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 230:80: E501 line too long (80 > 79 characters)

Comment last updated at 2021-05-18 14:53:26 UTC

@dalmia dalmia temporarily deployed to Staging May 18, 2021 14:53 Inactive
@dalmia dalmia merged commit b4fa6a8 into master May 18, 2021
@dalmia dalmia deleted the feature/cognito-support branch May 18, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalmia dalmia dalmia approved these changes

@deepansh96 deepansh96 Awaiting requested review from deepansh96

Assignees

@rathorevaibhav rathorevaibhav

Labels
None yet
Projects
None yet
Milestone
v0.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@rathorevaibhav @pep8speaks @dalmia