Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api permissions scaffolding #171

Merged
merged 9 commits into from
May 26, 2021
Merged

Api permissions scaffolding #171

merged 9 commits into from
May 26, 2021

Conversation

rathorevaibhav
Copy link
Member

@rathorevaibhav rathorevaibhav commented May 25, 2021 •
edited
Loading

Fixes #147

Summary

Basic API permissions

Test Plan

  • Tested locally
  • Tested on staging
  • Tested on production

@rathorevaibhav rathorevaibhav temporarily deployed to Staging May 25, 2021 10:27 Inactive
@rathorevaibhav rathorevaibhav self-assigned this May 25, 2021
@rathorevaibhav rathorevaibhav added this to the v0.2 milestone May 25, 2021
@rathorevaibhav rathorevaibhav temporarily deployed to Staging May 25, 2021 13:09 Inactive
@rathorevaibhav rathorevaibhav temporarily deployed to Staging May 25, 2021 15:44 Inactive
@rathorevaibhav rathorevaibhav temporarily deployed to Staging May 25, 2021 15:47 Inactive
dalmia
dalmia reviewed May 25, 2021
View reviewed changes
plio/permissions.py Outdated Show resolved Hide resolved
dalmia
dalmia reviewed May 25, 2021
View reviewed changes
users/permissions.py Outdated Show resolved Hide resolved
@pep8speaks
Copy link

pep8speaks commented May 26, 2021 •
edited
Loading

Hello @rathorevaibhav! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:80: E501 line too long (132 > 79 characters)

Line 13:80: E501 line too long (116 > 79 characters)
Line 17:80: E501 line too long (119 > 79 characters)

Line 10:80: E501 line too long (116 > 79 characters)
Line 18:80: E501 line too long (119 > 79 characters)

Comment last updated at 2021-05-26 06:30:08 UTC

dalmia
dalmia reviewed May 26, 2021
View reviewed changes
plio/permissions.py Outdated Show resolved Hide resolved
@dalmia dalmia temporarily deployed to Staging May 26, 2021 06:30 Inactive
@dalmia dalmia merged commit 020b3fd into master May 26, 2021
@dalmia dalmia deleted the feature/api-permissions branch May 26, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalmia dalmia dalmia left review comments

@deepansh96 deepansh96 deepansh96 approved these changes

Assignees

@rathorevaibhav rathorevaibhav

Labels
None yet
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.

API permissions/access tasks
4 participants
@rathorevaibhav @pep8speaks @dalmia @deepansh96