Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort plios by name, created_at, updated_at, number_of_viewers #174

Merged
merged 7 commits into from
May 27, 2021

Conversation

deepansh96
Copy link
Member

@deepansh96 deepansh96 commented May 27, 2021

Fixes #173

Test Plan

  • Tested locally
  • Tested on staging
  • Tested on production

@pep8speaks
Copy link

pep8speaks commented May 27, 2021

Hello @deepansh96! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 19:80: E501 line too long (80 > 79 characters)
Line 21:80: E501 line too long (89 > 79 characters)
Line 26:80: E501 line too long (84 > 79 characters)
Line 55:80: E501 line too long (94 > 79 characters)
Line 56:80: E501 line too long (92 > 79 characters)
Line 67:80: E501 line too long (82 > 79 characters)

Comment last updated at 2021-05-27 08:23:52 UTC

@deepansh96 deepansh96 temporarily deployed to Staging May 27, 2021 00:34 Inactive
@deepansh96 deepansh96 added enhancement New feature or request feature Adds a new feature labels May 27, 2021
@deepansh96 deepansh96 added this to the v0.2 milestone May 27, 2021
plio/ordering.py Outdated Show resolved Hide resolved
plio/ordering.py Outdated Show resolved Hide resolved
plio/ordering.py Outdated Show resolved Hide resolved
plio/ordering.py Outdated Show resolved Hide resolved
plio/ordering.py Outdated Show resolved Hide resolved
plio/ordering.py Outdated Show resolved Hide resolved
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
plio/ordering.py Outdated Show resolved Hide resolved
plio/ordering.py Outdated Show resolved Hide resolved
plio/ordering.py Outdated Show resolved Hide resolved
@deepansh96 deepansh96 temporarily deployed to Staging May 27, 2021 07:39 Inactive
plio/ordering.py Outdated Show resolved Hide resolved
@deepansh96 deepansh96 temporarily deployed to Staging May 27, 2021 08:23 Inactive
@dalmia dalmia merged commit e9b39a1 into master May 27, 2021
@dalmia dalmia deleted the support_for_sorting_plios branch May 27, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature Adds a new feature
Projects
None yet
3 participants