Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/testing #181

Merged
merged 24 commits into from
Jun 9, 2021
Merged

Feature/testing #181

merged 24 commits into from
Jun 9, 2021

Conversation

rathorevaibhav
Copy link
Member

@rathorevaibhav rathorevaibhav commented Jun 8, 2021

Fixes #180

Summary

  1. SMS_DRIVER introduced to avoid SMS sending when testing.
  2. Pre-commit CI yml merged with test cases CI. Instead of two CI runs, we'll have two jobs within one CI. More or less same.
  3. Removed TenantMainMiddleware from middleware list as it was the reason for 404 errors in all test cases. Since, Organization middleware inherits the TenantMainMiddleware, it is placed on top now.
  4. Test case added for User Authentication

Test Plan

  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema

Additional

Because of middleware changes, I'll need help in testing functionalities manually. I've tested locally and there doesn't seem to be any issue.

@pep8speaks
Copy link

pep8speaks commented Jun 8, 2021

Hello @rathorevaibhav! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 11:80: E501 line too long (85 > 79 characters)
Line 16:80: E501 line too long (120 > 79 characters)
Line 17:80: E501 line too long (105 > 79 characters)
Line 39:80: E501 line too long (85 > 79 characters)

Line 135:80: E501 line too long (132 > 79 characters)

Comment last updated at 2021-06-09 10:35:01 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@532d2d3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #181   +/-   ##
=========================================
  Coverage          ?   75.46%           
=========================================
  Files             ?      108           
  Lines             ?     1406           
  Branches          ?        0           
=========================================
  Hits              ?     1061           
  Misses            ?      345           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532d2d3...ad3a0bf. Read the comment docs.

.env.example Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
.github/workflows/ci.yml Outdated Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
@dalmia dalmia merged commit 3c1d194 into master Jun 9, 2021
@dalmia dalmia deleted the feature/testing branch June 9, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up automated testing
4 participants