Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More test cases #183

Merged
merged 8 commits into from
Jun 10, 2021
Merged

More test cases #183

merged 8 commits into from
Jun 10, 2021

Conversation

rathorevaibhav
Copy link
Member

@rathorevaibhav rathorevaibhav commented Jun 9, 2021

Summary

  1. A few more test cases added.
  2. Test cases files skeleton are in place. More test cases to be added separately. Please refer Add Test cases #184
  3. Fixes Resolve DateTime warning #125

Test Plan

  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema

@pep8speaks
Copy link

pep8speaks commented Jun 9, 2021

Hello @rathorevaibhav! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 19:80: E501 line too long (85 > 79 characters)
Line 24:80: E501 line too long (120 > 79 characters)
Line 25:80: E501 line too long (105 > 79 characters)
Line 48:80: E501 line too long (87 > 79 characters)
Line 61:80: E501 line too long (82 > 79 characters)
Line 62:80: E501 line too long (82 > 79 characters)
Line 82:80: E501 line too long (81 > 79 characters)
Line 87:80: E501 line too long (83 > 79 characters)

Line 56:80: E501 line too long (84 > 79 characters)
Line 74:80: E501 line too long (81 > 79 characters)

Line 12:80: E501 line too long (87 > 79 characters)

Line 124:80: E501 line too long (84 > 79 characters)

Comment last updated at 2021-06-10 12:50:16 UTC

@rathorevaibhav rathorevaibhav marked this pull request as ready for review June 10, 2021 06:06
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #183 (af61749) into master (3c1d194) will increase coverage by 4.43%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #183      +/-   ##
==========================================
+ Coverage   75.46%   79.89%   +4.43%     
==========================================
  Files         108      113       +5     
  Lines        1406     1537     +131     
==========================================
+ Hits         1061     1228     +167     
+ Misses        345      309      -36     
Impacted Files Coverage Δ
entries/tests.py 100.00% <100.00%> (ø)
experiments/tests.py 100.00% <100.00%> (ø)
organizations/tests.py 100.00% <100.00%> (ø)
plio/settings.py 100.00% <100.00%> (ø)
plio/tests.py 100.00% <100.00%> (ø)
plio/urls.py 100.00% <100.00%> (ø)
tags/tests.py 100.00% <100.00%> (ø)
users/tests.py 100.00% <100.00%> (ø)
users/views.py 65.35% <100.00%> (-0.52%) ⬇️
users/models.py 66.34% <0.00%> (-7.70%) ⬇️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1d194...af61749. Read the comment docs.

@rathorevaibhav rathorevaibhav added this to the v0.2.2 milestone Jun 10, 2021
plio/urls.py Outdated Show resolved Hide resolved
plio/urls.py Outdated Show resolved Hide resolved
plio/urls.py Outdated Show resolved Hide resolved
organizations/tests.py Outdated Show resolved Hide resolved
organizations/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
Co-authored-by: Aman Dalmia <amandalmia18@gmail.com>
@rathorevaibhav rathorevaibhav temporarily deployed to Staging June 10, 2021 12:50 Inactive
@dalmia dalmia merged commit 83b0445 into master Jun 10, 2021
@dalmia dalmia deleted the feature/testing-apps branch June 10, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve DateTime warning
4 participants