Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cases for plio app #194

Merged
merged 20 commits into from
Jun 19, 2021
Merged

Test cases for plio app #194

merged 20 commits into from
Jun 19, 2021

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented Jun 18, 2021

Fixes #193

Summary

  • tests for several endpoints in the plio, item, question and image tables.

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema

@pep8speaks
Copy link

pep8speaks commented Jun 18, 2021

Hello @dalmia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 43:80: E501 line too long (81 > 79 characters)
Line 47:80: E501 line too long (88 > 79 characters)
Line 102:80: E501 line too long (84 > 79 characters)
Line 114:80: E501 line too long (83 > 79 characters)
Line 147:80: E501 line too long (84 > 79 characters)
Line 150:80: E501 line too long (83 > 79 characters)
Line 154:80: E501 line too long (85 > 79 characters)
Line 241:80: E501 line too long (85 > 79 characters)
Line 251:80: E501 line too long (89 > 79 characters)
Line 254:80: E501 line too long (88 > 79 characters)
Line 268:80: E501 line too long (88 > 79 characters)
Line 323:80: E501 line too long (80 > 79 characters)
Line 341:80: E501 line too long (83 > 79 characters)
Line 367:80: E501 line too long (83 > 79 characters)
Line 404:80: E501 line too long (83 > 79 characters)
Line 408:80: E501 line too long (85 > 79 characters)
Line 463:80: E501 line too long (80 > 79 characters)
Line 485:80: E501 line too long (80 > 79 characters)
Line 488:80: E501 line too long (88 > 79 characters)
Line 493:80: E501 line too long (87 > 79 characters)
Line 512:80: E501 line too long (88 > 79 characters)
Line 521:80: E501 line too long (81 > 79 characters)
Line 537:80: E501 line too long (88 > 79 characters)
Line 561:80: E501 line too long (80 > 79 characters)

Line 281:80: E501 line too long (81 > 79 characters)

Comment last updated at 2021-06-19 09:03:56 UTC

@dalmia dalmia added this to the v0.2.2 milestone Jun 18, 2021
@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #194 (ac2f487) into master (2bad47b) will increase coverage by 4.59%.
The diff coverage is 99.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #194      +/-   ##
==========================================
+ Coverage   81.74%   86.33%   +4.59%     
==========================================
  Files         115      115              
  Lines        1687     1830     +143     
==========================================
+ Hits         1379     1580     +201     
+ Misses        308      250      -58     
Impacted Files Coverage Δ
plio/views.py 80.89% <90.00%> (+33.52%) ⬆️
plio/tests.py 100.00% <100.00%> (ø)
organizations/middleware.py 84.00% <0.00%> (+8.00%) ⬆️
plio/serializers.py 97.72% <0.00%> (+13.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bad47b...ac2f487. Read the comment docs.

plio/tests.py Outdated
self.assertEqual(image.alt_text, response.data["alt_text"])
self.assertEqual(image.url.file.size, new_image.url.file.size)

# before merge, update Vaibhav's changes for org and new user - use
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been kept as a reminder based on whether Vaibhav's or this PR gets merged first. Will remove it before merging.

@dalmia dalmia changed the title WIP: test cases for plio_uuid Test cases for plio app Jun 18, 2021
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Outdated Show resolved Hide resolved
plio/tests.py Show resolved Hide resolved
@dalmia dalmia merged commit 04744dc into master Jun 19, 2021
@dalmia dalmia deleted the plio-tests branch June 19, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More tests for plio app
3 participants