Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Users App #197

Merged
merged 10 commits into from
Jun 19, 2021
Merged

Tests for Users App #197

merged 10 commits into from
Jun 19, 2021

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented Jun 19, 2021

Fixes #196

Summary

  • tests for user, organization-user and other functions defined in users/views.py
  • added analytics env variables to CI for testing the function to fetch analytics app access token
  • created a config file for pep8speaks

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema

@pep8speaks
Copy link

pep8speaks commented Jun 19, 2021

Hello @dalmia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-19 09:28:26 UTC

@dalmia dalmia added this to the v0.2.2 milestone Jun 19, 2021
@dalmia dalmia changed the base branch from master to plio-tests June 19, 2021 03:41
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #197 (09e32bf) into master (04744dc) will increase coverage by 2.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   86.33%   89.06%   +2.73%     
==========================================
  Files         115      115              
  Lines        1830     1903      +73     
==========================================
+ Hits         1580     1695     +115     
+ Misses        250      208      -42     
Impacted Files Coverage Δ
plio/urls.py 100.00% <ø> (ø)
users/tests.py 100.00% <100.00%> (ø)
users/views.py 90.69% <100.00%> (+22.19%) ⬆️
users/serializers.py 96.55% <0.00%> (+6.89%) ⬆️
users/models.py 76.92% <0.00%> (+7.69%) ⬆️
users/permissions.py 46.15% <0.00%> (+10.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04744dc...09e32bf. Read the comment docs.

@dalmia dalmia changed the title WIP: Tests for Users App Tests for Users App Jun 19, 2021
users/tests.py Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
users/tests.py Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
Base automatically changed from plio-tests to master June 19, 2021 09:26
@dalmia dalmia merged commit c52eef6 into master Jun 19, 2021
@dalmia dalmia deleted the user-tests branch June 19, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More tests for user app
3 participants