Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use permissions to restrict access instead of queryset #253

Merged
merged 3 commits into from
Nov 7, 2021

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented Nov 2, 2021

Fixes #252

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@dalmia dalmia added this to the v0.4.1 milestone Nov 2, 2021
@dalmia dalmia temporarily deployed to Staging November 3, 2021 04:37 Inactive
@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #253 (78e0bc8) into master (883e656) will increase coverage by 0.03%.
The diff coverage is 97.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   96.92%   96.96%   +0.03%     
==========================================
  Files         143      143              
  Lines        2669     2668       -1     
==========================================
  Hits         2587     2587              
+ Misses         82       81       -1     
Impacted Files Coverage Δ
plio/views.py 94.88% <90.00%> (+0.53%) ⬆️
plio/permissions.py 95.45% <100.00%> (ø)
plio/tests.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 883e656...78e0bc8. Read the comment docs.

@deepansh96
Copy link
Member

I was not able to understand / forgot why this PR was needed and why the specified changes were made, please explain it to me on call

@dalmia dalmia merged commit a98f833 into master Nov 7, 2021
@dalmia dalmia deleted the remove-plio-queryset branch November 7, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Plio Permission to restrict access to plios instead of using queryset
2 participants