Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for checkbox questions #258

Merged
merged 12 commits into from
Dec 15, 2021
Merged

Add support for checkbox questions #258

merged 12 commits into from
Dec 15, 2021

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented Nov 25, 2021

Fixes #260
Fixes #261

Summary

  • added checkbox as another valid question type
  • changed data type of answer in session answer to JSONField
  • changed data type of correct_answer in question to JSONField
  • updates the README accompanying a plio's report to make it clearer
  • in the report, we were giving correct_answer 1-indexed but session answer as 0-indexed. Made it 1-indexed for both now.

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #258 (55734b9) into master (6f36eb6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   96.96%   96.99%   +0.03%     
==========================================
  Files         144      147       +3     
  Lines        2667     2696      +29     
==========================================
+ Hits         2586     2615      +29     
  Misses         81       81              
Impacted Files Coverage Δ
plio/config.py 100.00% <ø> (ø)
plio/queries.py 100.00% <ø> (ø)
entries/migrations/0028_auto_20211130_0828.py 100.00% <100.00%> (ø)
entries/models.py 98.07% <100.00%> (ø)
plio/migrations/0027_auto_20210902_1049.py 100.00% <100.00%> (ø)
plio/migrations/0028_auto_20210902_1120.py 100.00% <100.00%> (ø)
plio/models.py 94.68% <100.00%> (ø)
plio/views.py 95.38% <100.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f36eb6...55734b9. Read the comment docs.

@dalmia dalmia temporarily deployed to Staging December 1, 2021 05:52 Inactive
@dalmia dalmia temporarily deployed to Staging December 7, 2021 08:59 Inactive
@dalmia dalmia added this to the v0.5.1 milestone Dec 7, 2021
@dalmia dalmia marked this pull request as ready for review December 7, 2021 12:59
plio/models.py Show resolved Hide resolved
entries/models.py Show resolved Hide resolved
plio/static/plio/docs/download_csv_README.md Outdated Show resolved Hide resolved
plio/static/plio/docs/download_csv_README.md Show resolved Hide resolved
@dalmia dalmia temporarily deployed to Staging December 13, 2021 04:03 Inactive
@dalmia dalmia temporarily deployed to Staging December 15, 2021 05:51 Inactive
@dalmia dalmia merged commit 9a83f59 into master Dec 15, 2021
@dalmia dalmia deleted the checkbox branch December 15, 2021 08:22
@dalmia dalmia modified the milestones: v0.5.1, v0.6 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants