Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables super-admin of an org to view true user identity + code cleanups #273

Merged
merged 9 commits into from
Dec 21, 2021

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented Dec 16, 2021

Fixes #272
Fixes #271
Fixes #270
Fixes #274

Summary

  • read the issues for the gist of what is being solved for
  • some code re-use and cleanup

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@dalmia dalmia temporarily deployed to Staging December 16, 2021 06:55 Inactive
@dalmia dalmia added this to the v0.5.1 milestone Dec 16, 2021
@avantifellows avantifellows deleted a comment from pep8speaks Dec 16, 2021
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #273 (7efa173) into master (39302d7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #273      +/-   ##
==========================================
+ Coverage   96.99%   97.01%   +0.01%     
==========================================
  Files         147      147              
  Lines        2696     2714      +18     
==========================================
+ Hits         2615     2633      +18     
  Misses         81       81              
Impacted Files Coverage Δ
plio/queries.py 100.00% <100.00%> (ø)
plio/tests.py 100.00% <100.00%> (ø)
plio/views.py 95.45% <100.00%> (+0.06%) ⬆️
users/config.py 100.00% <100.00%> (ø)
users/models.py 97.36% <100.00%> (+0.14%) ⬆️
users/permissions.py 89.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39302d7...7efa173. Read the comment docs.

@pep8speaks
Copy link

pep8speaks commented Dec 16, 2021

Hello @dalmia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 39:101: E501 line too long (128 > 100 characters)
Line 61:101: E501 line too long (128 > 100 characters)
Line 89:101: E501 line too long (128 > 100 characters)

Comment last updated at 2021-12-21 02:05:27 UTC

@dalmia dalmia temporarily deployed to Staging December 16, 2021 07:36 Inactive
@dalmia dalmia temporarily deployed to Staging December 16, 2021 09:46 Inactive
@dalmia dalmia temporarily deployed to Staging December 16, 2021 10:14 Inactive
@dalmia dalmia temporarily deployed to Staging December 16, 2021 10:31 Inactive
plio/static/plio/docs/download_csv_README.md Show resolved Hide resolved
users/models.py Outdated Show resolved Hide resolved
users/models.py Outdated Show resolved Hide resolved
@dalmia dalmia merged commit ce62d96 into master Dec 21, 2021
@dalmia dalmia deleted the unmask-user-id branch December 21, 2021 03:43
@dalmia dalmia modified the milestones: v0.5.1, v0.6 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment