Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks whether correct params have been passed during OTP verification #304

Merged
merged 6 commits into from
Jan 20, 2022

Conversation

Manyakalra3
Copy link
Contributor

@Manyakalra3 Manyakalra3 commented Jan 19, 2022

Fixes #301

Summary

Tests are written for testing whether Params (mobile and otp) have been passed during the OTP verification.

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If adding any new environment variable:
    • update docs/ENV.md
    • update the environment variables for staging and production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@pep8speaks
Copy link

pep8speaks commented Jan 19, 2022

Hello @Manyakalra3! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-20 05:11:21 UTC

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #304 (2233d74) into master (b07c168) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   97.01%   97.02%   +0.01%     
==========================================
  Files         147      147              
  Lines        2714     2725      +11     
==========================================
+ Hits         2633     2644      +11     
  Misses         81       81              
Impacted Files Coverage Δ
users/tests.py 100.00% <100.00%> (ø)
users/views.py 96.85% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07c168...2233d74. Read the comment docs.

users/views.py Outdated Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
users/tests.py Outdated Show resolved Hide resolved
@Manyakalra3 Manyakalra3 temporarily deployed to Staging January 20, 2022 05:11 Inactive
@dalmia dalmia merged commit a784462 into master Jan 20, 2022
@dalmia dalmia deleted the mobileandotp branch January 20, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For otp verification, check that both mobile and OTP have been given
3 participants