Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes CMS_TOKEN #305

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Removes CMS_TOKEN #305

merged 2 commits into from
Jan 20, 2022

Conversation

Salonichoudhary07
Copy link
Contributor

@Salonichoudhary07 Salonichoudhary07 commented Jan 19, 2022

Fixes #297

Summary

CMS_TOKEN was not being used at the backend.

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If adding or removing any environment variable:
    • update docs/ENV.md
    • update the environment variables for staging and production
  • If changes in DB, update [DB schema] and BigQuery (staging and prod)

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #305 (21dbb9b) into master (ef4f6ec) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   97.01%   97.01%   -0.01%     
==========================================
  Files         147      147              
  Lines        2714     2713       -1     
==========================================
- Hits         2633     2632       -1     
  Misses         81       81              
Impacted Files Coverage Δ
plio/settings.py 87.01% <ø> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef4f6ec...21dbb9b. Read the comment docs.

Copy link
Member

@deepansh96 deepansh96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes

.env.example Outdated Show resolved Hide resolved
docs/ENV.md Outdated Show resolved Hide resolved
.env.example Outdated Show resolved Hide resolved
@deepansh96 deepansh96 removed the request for review from rathorevaibhav January 19, 2022 16:22
@deepansh96 deepansh96 closed this Jan 20, 2022
@deepansh96 deepansh96 reopened this Jan 20, 2022
@deepansh96 deepansh96 temporarily deployed to Staging January 20, 2022 04:40 Inactive
@Salonichoudhary07 Salonichoudhary07 changed the title added check for removing CMS_TOKEN Removes CMS_TOKEN Jan 20, 2022
@dalmia dalmia merged commit b10b6d9 into master Jan 20, 2022
@dalmia dalmia deleted the cmstoken_removed branch January 20, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PLIO_CMS_TOKEN from environment variables
3 participants