Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes support for plio-analytics and BIGQUERY #310

Merged
merged 26 commits into from
Jan 27, 2022
Merged

Conversation

dalmia
Copy link
Member

@dalmia dalmia commented Jan 21, 2022

Fixes #309

Summary

  • removed the list_uuid endpoint and instead updated the list endpoint to return a paginated list of plio details with each plio object also containing the items associated with that plio (this is because of the way duplicate is implemented - created an issue to fix that later) + number of unique views.
  • removed support for BigQuery and making all queries directly on RDS
  • added a new endpoint for computing metrics for a plio
  • removed everything related to BigQuery and plio-analytics

Test Plan

  • Wrote tests
  • Tested locally
  • Tested on staging
  • Tested on production
  • If adding or removing any environment variable:
    • update docs/ENV.md
    • update the environment variables for staging and production
  • If changes in DB, update DB schema and BigQuery (staging and prod)

@pep8speaks
Copy link

pep8speaks commented Jan 21, 2022

Hello @dalmia! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-01-27 09:10:53 UTC

@dalmia dalmia temporarily deployed to Staging January 21, 2022 20:16 Inactive
@dalmia dalmia temporarily deployed to Staging January 21, 2022 20:32 Inactive
@codecov
Copy link

codecov bot commented Jan 24, 2022

Codecov Report

Merging #310 (79d8d96) into master (b77fb30) will increase coverage by 0.37%.
The diff coverage is 100.00%.

❗ Current head 79d8d96 differs from pull request most recent head c6fa4f7. Consider uploading reports for the commit c6fa4f7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   97.19%   97.57%   +0.37%     
==========================================
  Files         148      150       +2     
  Lines        2851     3007     +156     
==========================================
+ Hits         2771     2934     +163     
+ Misses         80       73       -7     
Impacted Files Coverage Δ
organizations/middleware.py 100.00% <ø> (ø)
plio/ordering.py 95.45% <ø> (-1.10%) ⬇️
plio/settings.py 86.66% <ø> (-0.35%) ⬇️
plio/urls.py 100.00% <ø> (ø)
users/tests.py 100.00% <ø> (ø)
users/views.py 97.52% <ø> (+0.62%) ⬆️
plio/migrations/0029_auto_20220124_2224.py 100.00% <100.00%> (ø)
plio/migrations/0030_merge_20220125_0510.py 100.00% <100.00%> (ø)
plio/models.py 94.84% <100.00%> (+0.05%) ⬆️
plio/queries.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b77fb30...c6fa4f7. Read the comment docs.

@dalmia dalmia temporarily deployed to Staging January 25, 2022 07:14 Inactive
@dalmia dalmia added this to the v0.5.1 milestone Jan 25, 2022
plio/queries.py Outdated Show resolved Hide resolved
@dalmia dalmia temporarily deployed to Staging January 25, 2022 08:04 Inactive
@dalmia dalmia temporarily deployed to Staging January 25, 2022 08:28 Inactive
@dalmia dalmia temporarily deployed to Staging January 25, 2022 10:37 Inactive
.github/workflows/ci.yml Show resolved Hide resolved
plio/models.py Show resolved Hide resolved
plio/views.py Outdated Show resolved Hide resolved
plio/views.py Show resolved Hide resolved
plio/views.py Show resolved Hide resolved
plio/views.py Outdated Show resolved Hide resolved
@deepansh96
Copy link
Member

  • You'll also remove all the instances related to the analytics service right? Auth0, cognito, ECR instances etc for both staging + production?
  • I had this stuff configured in my .env file. These instances will also be shut down and deleted right?
    image

@dalmia dalmia temporarily deployed to Staging January 27, 2022 07:34 Inactive
plio/queries.py Outdated Show resolved Hide resolved
@dalmia dalmia merged commit 89e8032 into master Jan 27, 2022
@dalmia dalmia deleted the remove-analytics branch January 27, 2022 09:12
@dalmia dalmia modified the milestones: v0.5.1, v0.6 Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for plio-analytics
3 participants