Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates on multitenancy #75

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

rathorevaibhav
Copy link
Member

Summary

  1. Installation steps updated on creating a public tenant. This is a required part of setup otherwise the package results in error.

Test Plan

Nothing required.

@rathorevaibhav rathorevaibhav self-assigned this Mar 29, 2021
@rathorevaibhav rathorevaibhav requested review from bohraji, deepansh96, pritamps and dalmia and removed request for bohraji March 29, 2021 08:32
@dalmia
Copy link
Member

dalmia commented Mar 30, 2021

Screenshot 2021-03-30 at 11 12 26 AM

I think this will be good after 2 minor changes: - either changing `psycopg2` to `psycopg2-binary` and checking if we still get the error / fixing it some other way - Adding the `createdb` command after starting postgres service in case the error that Deepansh highlighted shows up.

@dalmia
Copy link
Member

dalmia commented Mar 31, 2021

@rathorevaibhav I went ahead and made the changes - let me know if it's fine!

@rathorevaibhav
Copy link
Member Author

@dalmia Did some testing and psycopg-binary is also working fine for me. This looks good!

@rathorevaibhav rathorevaibhav merged commit 7d263d5 into master Mar 31, 2021
@rathorevaibhav rathorevaibhav deleted the feature/documentation-updates branch March 31, 2021 08:02
@dalmia dalmia added this to the v0.1 milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants