Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC solution #393

Merged
merged 11 commits into from
Apr 4, 2024
Merged

MSVC solution #393

merged 11 commits into from
Apr 4, 2024

Conversation

assertivist
Copy link
Member

⚠️This PR is open to test CI updates and other platforms, but it should not be merged until at LEAST one Windows user reports that a test build runs and plays online.⚠️

Adds a MSVC solution that builds the existing codebase and loads dependencies (SDL2, glad, gtest) on Windows with "vcpkg".

Minor outstanding things

  • no header or source groups for our source folder structure, its all flat
  • Include paths specified as "additional includes" - related to above

Updates the CI "nightly" download to use this build instead of the MinGW MSYS2 build.

The only source changes have to do with a handful of allocations and a few spots where MSVC prefers to have Windows.h included first (or where headers simply don't exist on Windows), and the tests are passing, so this should be network compatible with main.

@assertivist assertivist merged commit 91133d3 into main Apr 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants