Avoid resolving dependencies at configuration time #264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #263.
In most cases, checking the dependency tree is not necessary, as
shouldRunAfter
does not add any tasks to the task graph. I think it's simpler to add the task ordering to allclasses
tasks in the project.However, this does change the behavior in certain cases. For example, if someone runs
./gradlew classes composeUp
with noisRequiredBy
, currently the plugin will have no ordering between the two tasks. These use cases seem unlikely to me though.I can change the implementation to use
taskGraph.whenReady
if you think that's better. That implementation is just harder to unit test, as it relies on Gradle's API.