Add regression tests for the new versions of VMProtect. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3rvac
reviewed
Apr 9, 2020
added 2 commits
April 9, 2020 10:24
Newer versions of VMProtect were not recognised, this test will ensure newer versions are properly recognised with `retdec-fileinfo`.
With the addition of the new heuristic detection method, we are now able to specify the version of the VMProtect more precisely and this fact should be reflected in the tests as well (since they were failing without the change).
tamaroth
force-pushed
the
improvement-vmprotect-detection
branch
from
02f0a8c
to
d5d4e8c
Compare
s3rvac
force-pushed
the
improvement-vmprotect-detection
branch
from
449b61f
to
d5d4e8c
Compare
s3rvac
approved these changes
Apr 9, 2020
There was a problem hiding this comment.
Approving 👍 I will merge it after avast/retdec#734 gets merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of VMProtect were not recognised, this test will ensure
newer versions are properly recognised with
retdec-fileinfo.