LLVM Error objects actually need to be consumed before their destruction

avast · Sep 19, 2023 · daed200 · daed200
1 parent b9791c8
commit daed200
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/fileformat/file_format/macho/macho_format.cpp b/src/fileformat/file_format/macho/macho_format.cpp
@@ -980,6 +980,7 @@ void MachOFormat::dyldInfoCommand(const llvm::object::MachOObjectFile::LoadComma
 		if (err)
 		{
 			// ignore errors
+			consumeError(std::move(err));
 		}
 	}
 
@@ -1005,6 +1006,7 @@ void MachOFormat::dyldInfoCommand(const llvm::object::MachOObjectFile::LoadComma
 		if (err)
 		{
 			// ignore errors
+			consumeError(std::move(err));
 		}
 	}
 
@@ -1024,6 +1026,7 @@ void MachOFormat::dyldInfoCommand(const llvm::object::MachOObjectFile::LoadComma
 		if (err)
 		{
 			// ignore errors
+			consumeError(std::move(err));
 		}
 	}
 
@@ -1043,6 +1046,7 @@ void MachOFormat::dyldInfoCommand(const llvm::object::MachOObjectFile::LoadComma
 		if (err)
 		{
 			// ignore errors
+			consumeError(std::move(err));
 		}
 	}
 }