Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bin2pat does not exit non-zero on failure #473

Closed
leftmostcat opened this issue Jan 27, 2019 · 1 comment
Closed

bin2pat does not exit non-zero on failure #473

leftmostcat opened this issue Jan 27, 2019 · 1 comment
Labels
bug C-bin2pat

Comments

@leftmostcat
Copy link
Contributor

The signature-from-library-creator.py script expects a non-zero result from bin2pat to indicate an error condition, but bin2pat exits with zero even in the case of a failure. Because the output of bin2pat is discarded, it fails silently and the result is an empty yara file.
@leftmostcat leftmostcat changed the title signature-from-library-creator does not recognize failure of bin2pat bin2pat does not exit non-zero on failure Jan 27, 2019
@leftmostcat leftmostcat mentioned this issue Jan 27, 2019
Merged
@s3rvac
Copy link
Member

s3rvac commented Jan 28, 2019

Fixed in #474 (thanks to @leftmostcat).

@s3rvac s3rvac closed this as completed Jan 28, 2019
s3rvac added a commit that referenced this issue Jan 28, 2019
@s3rvac
Add a new CHANGELOG entry (#473, #474).
8b1ece1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C-bin2pat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leftmostcat @s3rvac