Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the original converter of LLVM IR into BIR from llvmir2hll #508

Closed
s3rvac opened this issue Feb 26, 2019 · 0 comments
Closed

Remove the original converter of LLVM IR into BIR from llvmir2hll #508

s3rvac opened this issue Feb 26, 2019 · 0 comments
Assignees
@s3rvac
Labels
C-llvmir2hll enhancement

Comments

@s3rvac
Copy link
Member

s3rvac commented Feb 26, 2019

Now that retdec-llvmir2hll is using the new converter of LLVM IR into BIR, we can remove the original (old) one. Reasons:

  • Nobody will probably ever use it.
  • We will not have to maintain two converters.
  • Fewer .cpp files to compile.
@s3rvac s3rvac self-assigned this Feb 26, 2019
s3rvac added a commit that referenced this issue Feb 26, 2019
@s3rvac
llvmir2hll: Remove the original converter of LLVM IR into BIR (#508).
edbe478 
Now that retdec-llvmir2hll is using the new converter of LLVM IR into BIR, we
can remove the original (old) one.

Reasons:
* Nobody will probably ever use it.
* We will not have to maintain two converters.
* Fewer `.cpp` files to compile.

Notes:
* We have to preserve labels_handler.cpp from the original converter as this
  module is also used by the new converter.
* The retdec-decompiler.py script had to be also updated (to prevent users from
  specifying 'orig' via --backend-llvmir2bir-converter.
@s3rvac s3rvac mentioned this issue Feb 26, 2019
Merged
s3rvac added a commit that referenced this issue Feb 28, 2019
@s3rvac
llvmir2hll: Remove the original converter of LLVM IR into BIR (#508).
885633a 
Now that retdec-llvmir2hll is using the new converter of LLVM IR into BIR, we
can remove the original (old) one.

Reasons:
* Nobody will probably ever use it.
* We will not have to maintain two converters.
* Fewer `.cpp` files to compile.

Notes:
* We have to preserve labels_handler.cpp from the original converter as this
  module is also used by the new converter.
* The retdec-decompiler.py script had to be also updated (to prevent users from
  specifying 'orig' via --backend-llvmir2bir-converter.
s3rvac added a commit that referenced this issue Feb 28, 2019
@s3rvac
Update a CHANGELOG entry to include changes in #508 and #509.
0dab270
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s3rvac s3rvac

Labels
C-llvmir2hll enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@s3rvac