-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new authenticode parser #1027
Conversation
I feel like Teamcity is not using the branch in regression-tests 🤔 |
@@ -14,6 +14,7 @@ endif() | |||
set(MSVC_GE $<BOOL:${MSVC}>) | |||
set(MSVC_CONFIG $<${MSVC_GE}:$<CONFIG>/>) | |||
|
|||
add_subdirectory(authenticode-parser) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for future reference, 1) this should also be added conditionaly (I will fix it in master
and send you a commit), 2) It would be easier for me to modify it if you used the avast/retdec
directly instead of your own fork, now that you have the rights. Maybe I could somehow modify your fork or this PR, but it complicates the things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!, okay, I'll switch to avast/retdec
repository for future
This PR replaces the current C++ Authenticode parser with https://github.com/avast/authenticode-parser
There are 2 main differences in the output:
The new parser is also able to extract more nested signatures as it treats nested signatures correctly as a Set. But because the library doesn't have access to the PE file, I've moved the file digest calculation into the
pe_format.cpp
.