Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API for OpenSSL 3.0 #1041

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Update API for OpenSSL 3.0 #1041

merged 1 commit into from
Nov 15, 2021

Conversation

catap
Copy link
Contributor

@catap catap commented Nov 7, 2021

Here a minor changes in OpenSSL API.

Fixes: #1040

@s3rvac
Copy link
Member

s3rvac commented Nov 8, 2021

@PeterMatula Do we want to use OpenSSL 3.0 in authenticode_parser when (1) the rest of RetDec uses OpenSSL 1.x and (2) many systems only have OpenSSL 1.x?

@catap
Copy link
Contributor Author

catap commented Nov 8, 2021

@s3rvac I feel that the right way is requires the same OpenSSL version everywhere. Right now it seems quite a mix. But I will wait of @PeterMatula response.

Anyway all another part of retdec is built fine with OpenSSL 3.

@catap
Copy link
Contributor Author

catap commented Nov 8, 2021

From another hand I may easy add a few ifdef to make the code universal.

@catap
Copy link
Contributor Author

catap commented Nov 8, 2021

Here it is. Right now it just introduced a compatibility with OpenSSL 3 without broken anything :)

@catap
Copy link
Contributor Author

catap commented Nov 8, 2021

@s3rvac I feel that I've overstep all your concern, am I wrong?

@s3rvac
Copy link
Member

s3rvac commented Nov 8, 2021

Yes, thank you 🙂. I will leave the review to @PeterMatula.

Copy link
Collaborator

@PeterMatula PeterMatula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I will trigger tests and if they pass I will merge.

Btw, these sources in deps are in fact from here avast/authenticode-parser, but because we wanted to reduce the number of external deps, we decided to "inline" this simple repo in RetDec directly. But not to worry, @HoundThe can you please integrate these changes back to avast/authenticode-parser?

And a second task, @HoundThe can you look into the question of "different OpenSSL versions" opened here? I would like to know, where (what other parts) are we using OpenSSL, which versions, and if they can all deal with OpenSSL 3.0.

@PeterMatula PeterMatula merged commit d35d7c1 into avast:master Nov 15, 2021
PeterMatula added a commit that referenced this pull request Nov 15, 2021
@catap catap deleted the openssl-3 branch November 15, 2021 10:54
@catap
Copy link
Contributor Author

catap commented Nov 15, 2021

@PeterMatula thanks!

Anyway, I'd love to share with you that v4.0 can't be build on system which has installed OpenSSL 3.0. Yes, it ships OpenSSL but system one is also used to build it. When your system has 1.x it is working, but with 3.0 => the hell is here.

The way to fix it is trivial: catap@6aa99fe

But it still, this patch need to be applied.

v4.0 also can't be build on Apple M1 because of embeded OpenSSL version which is too old.

And here I'd love to ask: maybe it is a good idea to release a new version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenSSL 3 support
3 participants