Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #384 - bin2llvmir: Be more strict when merging values #399

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #384 - bin2llvmir: Be more strict when merging values #399

wants to merge 1 commit into from

Conversation

palant
Copy link
Contributor

@palant palant commented Sep 14, 2018

This fixes the issues mentioned in #384. I merely removed the check that made load result and the load origin considered equivalent, this is definitely wrong. Maybe some other checks here are also wrong, I can't really tell.

@palant
Copy link
Contributor Author

palant commented Sep 14, 2018

Massive test fallout 😞
I guess that this change is a no-go. But maybe you could help me understand why it has such a massive impact.

@PeterMatula
Copy link
Collaborator

I will look into this. I think there might be something there - the change is not entirely bad and might make sense. But it looks like many RetDec parts are relying on the original behavior - maybe they should not and it should be solved in a different manner.

@s3rvac
Copy link
Member

s3rvac commented Feb 5, 2019

@PeterMatula Were you able to look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants