Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more than half the stack usage of CFG traversal #492

Merged
merged 1 commit into from
Feb 7, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/llvmir2hll/graphs/cfg/cfg_traversal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ bool CFGTraversal::getCurrRetVal() const {
}

/**
* @brief A recursive implementation of performTraversal().
* @brief A non-recursive implementation of performTraversal().
*
* @param[in] node Node to be traversed.
* @param[in] stmtIter Iterator to a statement in @a node to be checked.
Expand All @@ -168,7 +168,7 @@ bool CFGTraversal::getCurrRetVal() const {
*/
dberlin marked this conversation as resolved.
Show resolved Hide resolved
bool CFGTraversal::performTraversalImpl(ShPtr<CFG::Node> node,
CFG::stmt_iterator stmtIter) {
if (stmtIter != node->stmt_end()) {
while (stmtIter != node->stmt_end()) {
// We're not at the end of the node, so check the statement under
// stmtIter.

Expand All @@ -182,15 +182,15 @@ bool CFGTraversal::performTraversalImpl(ShPtr<CFG::Node> node,
return getCurrRetVal();
}

return performTraversalImpl(node, ++stmtIter);
++stmtIter;
}

// We have reached the end of the node, so check node's successors.
return traverseNodeSuccessors(node);
}

/**
* @brief A recursive implementation of performReverseTraversal().
* @brief A non-recursive implementation of performReverseTraversal().
*
* @param[in] node Node to be traversed.
* @param[in] stmtRIter Reverse iterator to a statement in @a node to be
Expand All @@ -202,7 +202,7 @@ bool CFGTraversal::performTraversalImpl(ShPtr<CFG::Node> node,
bool CFGTraversal::performReverseTraversalImpl(ShPtr<CFG::Node> node,
CFG::stmt_reverse_iterator stmtRIter) {

if (stmtRIter != node->stmt_rend()) {
while (stmtRIter != node->stmt_rend()) {
// We're not at the start of the node, so check the statement under
// stmtRIter.

Expand All @@ -216,7 +216,7 @@ bool CFGTraversal::performReverseTraversalImpl(ShPtr<CFG::Node> node,
return getCurrRetVal();
}

return performReverseTraversalImpl(node, ++stmtRIter);
++stmtRIter;
}

// We have reached the start of the node, so check node's predecessors.
Expand Down