Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix issue #638 #642

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Try to fix issue #638 #642

merged 1 commit into from
Dec 7, 2022

Conversation

seviezhou
Copy link
Contributor

Reference: #638

@PeterMatula
Copy link
Collaborator

Maybe, lets Run TeamCity builds and see if everything is ok.

@s3rvac
Copy link
Member

s3rvac commented Sep 16, 2019

Not all TeamCity builds have been run. Let's run TeamCity builds again.

@s3rvac
Copy link
Member

s3rvac commented Sep 16, 2019

One of our regression tests started failing with the proposed fix:

[Step 5/6] integration.switch.Test_MSVC (switch-test-msvc-O0.ex)                  [ FAIL ]  (1.77s)
[Step 5/6] ...F
[Step 5/6] ======================================================================
[Step 5/6] FAIL: test_issue_636 (integration.switch.Test_MSVC)
[Step 5/6] ----------------------------------------------------------------------
[Step 5/6] Traceback (most recent call last):
[Step 5/6]   File "retdec-regression-tests\integration\switch\test.py", line 177, in test_issue_636
[Step 5/6]     assert self.out_c.contains('char \* g9; // 0x419548')
[Step 5/6] AssertionError
[Step 5/6]
[Step 5/6] ----------------------------------------------------------------------
[Step 5/6] Ran 4 tests in 0.108s
[Step 5/6]
[Step 5/6] FAILED (failures=1)

@PeterMatula, can you please take a look?

@PeterMatula PeterMatula merged commit 8cabc04 into avast:master Dec 7, 2022
@PeterMatula
Copy link
Collaborator

The test is no longer failing. I diffed the before and after and found no obvious regression. It could possibly be solved more robustly, but the change makes sense and does some good. Thanks @seviezhou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants