Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detection support of Astrum InstallWizard. #753

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

tamaroth
Copy link
Contributor

@tamaroth tamaroth commented Apr 24, 2020

Astrum InstallWizard is an installation software from Thraex Software and this PR aims at providing Fileinfo an ability to detect installation files, created using that software, correctly.

The tests for this enhancment were added here.

Astrum InstallWizard is an installation software from Thraex Software.
@s3rvac
Copy link
Member

s3rvac commented Apr 24, 2020

Let's run TeamCity tests.

Copy link
Member

@s3rvac s3rvac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The TC builds fail because the PR is not based on the current RetDec's master but the tests in avast/retdec-regression-tests#53 are based on the RetDec tests' master. Other than that, there is nothing wrong with the PR, so approving 👍

A tip for the future: Always base both PRs (RetDec and tests) on the current master.

@s3rvac s3rvac merged commit 400d997 into master Apr 25, 2020
@s3rvac s3rvac deleted the improvement-astrum-detection branch April 25, 2020 09:45
s3rvac added a commit that referenced this pull request Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants